From 2f1993cf06de97bfa367d5d5dbd6ba8c191523e8 Mon Sep 17 00:00:00 2001 From: johnjbarton Date: Fri, 9 Nov 2018 17:11:17 -0800 Subject: [PATCH] fix(console): Re-add Error: to the stack Chrome devtools looks for a pattern in stack traces and if it finds a match it will shorten and linkify the stack, and apply sourcemaps. The pattern fails when the "Error: " is removed. So we put it back for debugging's sake. --- src/adapter.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/adapter.js b/src/adapter.js index 29c8995..36bbf54 100644 --- a/src/adapter.js +++ b/src/adapter.js @@ -70,6 +70,7 @@ function formatFailedStep (step) { // Remove the message prior to processing the stack to prevent issues like // https://github.com/karma-runner/karma-jasmine/issues/79 var stack = step.stack.replace('Error: ' + step.message, '') + var prefix = (stack === step.stack) ? '' : 'Error: ' var dirtyRelevantStack = getRelevantStackFrom(stack) @@ -85,14 +86,14 @@ function formatFailedStep (step) { } else { // Stack entry is already in the message, // we consider it to be a suitable message alternative: - relevantMessage.push(dirtyRelevantStack[i]) + relevantMessage.push(prefix + dirtyRelevantStack[i]) } } // In most cases the above will leave us with an empty message... if (relevantMessage.length === 0) { // Let's reuse the original message: - relevantMessage.push(step.message) + relevantMessage.push(prefix + step.message) // Now we probably have a repetition case where: // relevantMessage: ["Expected true to be false."]