fix(time): report correct time since Jasmine v2.9.0 #197

nicojs · 2018-03-09T17:44:44Z

Time reporting broke since jasmine-core v2.9 because the reporter API
now receives copies of spec results instead of the real deal.
We cannot rely on the same object being passed around.

Fixes #196

Time reporting broke since jasmine-core v2.9 because the reporter API now receives copies of spec results instead of the real deal. We cannot rely on the same object being passed around.

nicojs · 2018-03-18T13:23:40Z

The failing build seems to have nothing to do with my change, but with components using new javascript syntax:

const gitconfig = require('gitconfiglocal');

billiegoose · 2018-03-27T02:51:34Z

Looks like master branch has been updated to drop support for the old versions of Node that were causing the tests to fail. If you try rebasing on the latest master, I bet the tests will pass now.

nicojs · 2018-03-27T06:44:47Z

@wmhilton that seems to work, Thanks! Can someone look at this now? 👍

johnjbarton · 2018-03-27T23:47:21Z

test/adapter.spec.js

@@ -253,6 +253,14 @@ describe('jasmine adapter', function () {
    it('should report time for every spec', function () {
      var counter = 3

+      function copySpecResult() {


I think this can just be

return spec.result.slice(0);

But in any case pass the spec as an arg to make it clearer.

johnjbarton · 2018-03-27T23:50:11Z

test/adapter.spec.js

@@ -262,8 +270,8 @@ describe('jasmine adapter', function () {
        expect(result.time).toBe(1) // 4 - 3
      })

-      reporter.specStarted(spec.result)
-      reporter.specDone(spec.result)
+      reporter.specStarted(copySpecResult())


or maybe reporter.specStarted(spec.result.slice(0))

How will that work? spec.result is not an array type: TypeError: spec.result.slice is not a function.

We could do something like JSON.parse(JSON.stringify(spec.result)) (or an other way of cloning the result) if you prefer.

How about
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign

Awesome! I've changed it:

reporter.specStarted(Object.assign({}, spec.result)) reporter.specDone(Object.assign({}, spec.result))

johnjbarton · 2018-03-28T16:57:22Z

Thanks!

## The devDependency [karma-jasmine](https://github.com/karma-runner/karma-jasmine) was updated from `1.1.2` to `2.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v2.0.0</summary> <ul> <li>feat (adapter): Use jasmine's new configure method (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="375153235" data-permission-text="Issue title is private" data-url="karma-runner/karma-jasmine#224" data-hovercard-type="pull_request" data-hovercard-url="/karma-runner/karma-jasmine/pull/224/hovercard" href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/pull/224">#224</a>) (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/6663e47">6663e47</a>), closes <a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/224" data-hovercard-type="pull_request" data-hovercard-url="/karma-runner/karma-jasmine/pull/224/hovercard">#224</a> <a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/221" data-hovercard-type="issue" data-hovercard-url="/karma-runner/karma-jasmine/issues/221/hovercard">#221</a></li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>adapter:</strong> Remove incorrect function and its call. (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/183" data-hovercard-type="pull_request" data-hovercard-url="/karma-runner/karma-jasmine/pull/183/hovercard">#183</a>) (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/cada4a9">cada4a9</a>)</li> <li>return false for every entry is irrelevant (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/206" data-hovercard-type="pull_request" data-hovercard-url="/karma-runner/karma-jasmine/pull/206/hovercard">#206</a>) (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/d7523d0">d7523d0</a>), closes <a href="https://urls.greenkeeper.io//github.com/karma-runner/karma-jasmine/pull/206/issues/discussion_r186142116">/github.com/karma-runner/karma-jasmine/pull/206#discussion_r186142116</a></li> <li><strong>console:</strong> Re-add Error: to the stack (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/228" data-hovercard-type="pull_request" data-hovercard-url="/karma-runner/karma-jasmine/pull/228/hovercard">#228</a>) (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/d0b980d">d0b980d</a>)</li> <li><strong>time:</strong> report correct time since Jasmine v2.9.0 (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/197" data-hovercard-type="pull_request" data-hovercard-url="/karma-runner/karma-jasmine/pull/197/hovercard">#197</a>) (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/022ee04">022ee04</a>), closes <a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/196" data-hovercard-type="issue" data-hovercard-url="/karma-runner/karma-jasmine/issues/196/hovercard">#196</a></li> </ul> <h3>Chores</h3> <ul> <li><strong>deps:</strong> Drop node v4 support. (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/214" data-hovercard-type="pull_request" data-hovercard-url="/karma-runner/karma-jasmine/pull/214/hovercard">#214</a>) (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/e604132">e604132</a>)</li> </ul> <h3>Features</h3> <ul> <li>Propagate errors thrown in afterAll blocks (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/f3fa264">f3fa264</a>), closes <a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/issues/161" data-hovercard-type="issue" data-hovercard-url="/karma-runner/karma-jasmine/issues/161/hovercard">#161</a></li> <li>update the version to 2.0.0 and restrict node version available to 4.0 (<a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/c84316e">c84316e</a>)</li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li><code>stopOnFailure</code>, which was previously documented in karma-jasmine's README, is<br> not configuration option for jasmine. Use <code>oneFailurePerSpec</code> instead.</li> </ul> <p>Requires peerDependency Jasmine@^3.3.0</p> <ul> <li><strong>deps:</strong> Drop support for node 4.x</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 9 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/2dbec133017572933d02d67a88673d5d67fb227a"><code>2dbec13</code></a> <code>chore: release v2.0.0</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/4ddfe2ffdf667c66eaddcc405c7042cdde685ddb"><code>4ddfe2f</code></a> <code>chore: update contributors</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/d0b980db3cb363b7fb0cd48dcd7d529aac83fbca"><code>d0b980d</code></a> <code>fix(console): Re-add Error: to the stack (#228)</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/6663e4733ad673472bfc4dae7c76d076370e5770"><code>6663e47</code></a> <code>feat (adapter): Use jasmine's new configure method (#224)</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/e604132ce243f685b5547745b9739c420a294729"><code>e604132</code></a> <code>chore(deps): Drop node v4 support. (#214)</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/66f598a5fd9b899f655e706576e725b02ccc3de1"><code>66f598a</code></a> <code>docs:(typo) timeoutInterval (#212)</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/5b45cc12618bf6591bbf8fb3271f2c608927fceb"><code>5b45cc1</code></a> <code>Adding timeout configuration option (#211)</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/d7523d0d89f89c8c4f454ddd83ef09da1858e207"><code>d7523d0</code></a> <code>fix: return false for every entry is irrelevant (#206)</code></li> <li><a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/commit/3b20480a5a1cfa769c2a1861455c76d3bfaaab52"><code>3b20480</code></a> <code>--grep option now supports real regular expressions but not masks only. (#204)</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/karma-runner/karma-jasmine/compare/b670e886dde410b6f28736985036e2ba6c74141e...2dbec133017572933d02d67a88673d5d67fb227a">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

fix(time): report correct time since Jasmine v2.9.0

3713801

Time reporting broke since jasmine-core v2.9 because the reporter API now receives copies of spec results instead of the real deal. We cannot rely on the same object being passed around.

billiegoose mentioned this pull request Mar 27, 2018

Tests say Success: null ms - a problem? isomorphic-git/isomorphic-git#110

Closed

Merge branch 'master' of github.com:karma-runner/karma-jasmine

8d2a914

nicojs force-pushed the fix-time branch from c0365bf to 1ed8ddd Compare March 27, 2018 06:29

johnjbarton reviewed Mar 27, 2018

View reviewed changes

johnjbarton suggested changes Mar 27, 2018

View reviewed changes

refactor(adapter): fix static code analysis warnings

a0b3ec8

nicojs force-pushed the fix-time branch from 1ed8ddd to a0b3ec8 Compare March 28, 2018 15:49

johnjbarton approved these changes Mar 28, 2018

View reviewed changes

johnjbarton merged commit 022ee04 into karma-runner:master Mar 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(time): report correct time since Jasmine v2.9.0 #197

fix(time): report correct time since Jasmine v2.9.0 #197

nicojs commented Mar 9, 2018 •

edited

nicojs commented Mar 18, 2018

billiegoose commented Mar 27, 2018

nicojs commented Mar 27, 2018

johnjbarton Mar 27, 2018

johnjbarton Mar 27, 2018

nicojs Mar 28, 2018

johnjbarton Mar 28, 2018

nicojs Mar 28, 2018

johnjbarton commented Mar 28, 2018

fix(time): report correct time since Jasmine v2.9.0 #197

fix(time): report correct time since Jasmine v2.9.0 #197

Conversation

nicojs commented Mar 9, 2018 • edited

nicojs commented Mar 18, 2018

billiegoose commented Mar 27, 2018

nicojs commented Mar 27, 2018

johnjbarton Mar 27, 2018

Choose a reason for hiding this comment

johnjbarton Mar 27, 2018

Choose a reason for hiding this comment

nicojs Mar 28, 2018

Choose a reason for hiding this comment

johnjbarton Mar 28, 2018

Choose a reason for hiding this comment

nicojs Mar 28, 2018

Choose a reason for hiding this comment

johnjbarton commented Mar 28, 2018

nicojs commented Mar 9, 2018 •

edited