Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On error in beforeAll/afterAll relevant information to debug are miss… #232

Merged
merged 3 commits into from Mar 25, 2019

Conversation

mschaaf
Copy link
Contributor

@mschaaf mschaaf commented Mar 18, 2019

…ing.

e.g. on Firefox no stack is available, but it can be one constructed if filename and
lineno are available.

…ing.

e.g. on Firefix no stack is available so construct one if filename and
lineno are available.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix the CI to not run on node v6.

src/adapter.js Outdated Show resolved Hide resolved
@mschaaf
Copy link
Contributor Author

mschaaf commented Mar 25, 2019

@johnjbarton Was is missing to get this merged?

@johnjbarton johnjbarton merged commit cd6f060 into karma-runner:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants