Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tools/integration-tests.sh to a cross-platform script #314

Open
XhmikosR opened this issue Apr 12, 2022 · 3 comments
Open

Convert tools/integration-tests.sh to a cross-platform script #314

XhmikosR opened this issue Apr 12, 2022 · 3 comments

Comments

@XhmikosR
Copy link
Collaborator

Requiring bash means one cannot run the tests on Windows native CMD. CI is passing right now because we specify shell: bash on Windows.
XhmikosR referenced this issue Apr 12, 2022
build: make integration-tests.sh verbose (set -x and -v)
a694098 
Also:

* Make it exit quick (set -x).
* Add its corresponding hashbang.
@jginsburgn
Copy link
Member

jginsburgn commented Apr 12, 2022 •
edited

In order to solve this, I can think of migrating the integration-tests.sh script to Node.js. Do you suggest any other alternative?

@XhmikosR
Copy link
Collaborator Author

Nope, that's the solution I'd go with too 👍

@jginsburgn
Copy link
Member

We are short on time, but let's keep this issue around for when someone can get to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @jginsburgn