Skip to content

Commit 1b9e1de

Browse files
authoredDec 15, 2020
fix(deps): bump socket-io to v3 (#3586)
* fix socket-io deprecated default export BREAKING CHANGE: Some projects have socket.io tests that are version sensitive. Fixes #3569
1 parent 3fed0bc commit 1b9e1de

File tree

3 files changed

+95
-276
lines changed

3 files changed

+95
-276
lines changed
 

‎lib/server.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,13 @@ const EmitterWrapper = require('./emitter_wrapper')
3636
const processWrapper = new EmitterWrapper(process)
3737

3838
function createSocketIoServer (webServer, executor, config) {
39-
const server = new SocketIO(webServer, {
39+
const server = new SocketIO.Server(webServer, {
4040
// avoid destroying http upgrades from socket.io to get proxied websockets working
4141
destroyUpgrade: false,
4242
path: config.urlRoot + 'socket.io/',
4343
transports: config.transports,
4444
forceJSONP: config.forceJSONP,
45-
// Default is 5000 in socket.io v2.x.
45+
// Default is 5000 in socket.io v2.x and v3.x.
4646
pingTimeout: config.pingTimeout || 5000
4747
})
4848

‎package-lock.json

+92-273
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@
422422
"qjobs": "^1.2.0",
423423
"range-parser": "^1.2.1",
424424
"rimraf": "^3.0.2",
425-
"socket.io": "^2.3.0",
425+
"socket.io": "^3.0.4",
426426
"source-map": "^0.6.1",
427427
"tmp": "0.2.1",
428428
"ua-parser-js": "^0.7.23",

0 commit comments

Comments
 (0)
Please sign in to comment.