Skip to content

Commit 91e7e00

Browse files
authoredOct 21, 2019
fix(ci): poll every 10s to avoid rate limit. (#3388)
Return to v1.5 karma-browserstack-launcher
1 parent 25d415e commit 91e7e00

File tree

2 files changed

+6
-18
lines changed

2 files changed

+6
-18
lines changed
 

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@
446446
"husky": "^0.14.3",
447447
"jasmine-core": "^3.4.0",
448448
"karma-browserify": "^6.0.0",
449-
"karma-browserstack-launcher": "^1.4.0",
449+
"karma-browserstack-launcher": "^1.5.0",
450450
"karma-chai": "^0.1.0",
451451
"karma-chrome-launcher": "^2.2.0",
452452
"karma-firefox-launcher": "*",

‎test/client/karma.conf.js

+5-17
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,6 @@ var launchers = {
4141
os: 'Windows',
4242
os_version: '7'
4343
}
44-
// TODO: Figure out why these fail on browserstack
45-
// ,
46-
// bs_ie_8: {
47-
// base: 'BrowserStack',
48-
// browser: 'ie',
49-
// browser_version: '8.0',
50-
// os: 'Windows',
51-
// os_version: '7'
52-
// },
53-
// bs_ie_7: {
54-
// base: 'BrowserStack',
55-
// browser: 'ie',
56-
// browser_version: '7.0',
57-
// os: 'Windows',
58-
// os_version: 'XP'
59-
// }
6044
}
6145

6246
var browsers = []
@@ -157,7 +141,11 @@ module.exports = function (config) {
157141
forceJSONP: true,
158142

159143
browserStack: {
160-
project: 'Karma'
144+
project: 'Karma',
145+
// The karma-browserstack-launcher polls for each browser.
146+
// With many browsers the 120 requests per minute limit is hit
147+
// resulting in fails Error: 403 Forbidden (Rate Limit Exceeded)
148+
pollingTimeout: 10000
161149
}
162150
})
163151
}

0 commit comments

Comments
 (0)
Please sign in to comment.