Skip to content

Commit dbd1943

Browse files
authoredFeb 1, 2021
fix: ensure that Karma supports running tests on IE 11 (#3642)
They were failing because of unsupported arrow function syntax in two places: - in karma.spec.js file (only affecting Karma's own tests) - in socket.io.js file installed from NPM, hence the dependency update (this affected Karma consumers) Enabled BrowserStack tests on IE 11 to prevent regressions.
1 parent 7a1344f commit dbd1943

File tree

4 files changed

+61
-76
lines changed

4 files changed

+61
-76
lines changed
 

‎package-lock.json

+47-47
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@
428428
"qjobs": "^1.2.0",
429429
"range-parser": "^1.2.1",
430430
"rimraf": "^3.0.2",
431-
"socket.io": "^3.0.4",
431+
"socket.io": "^3.1.0",
432432
"source-map": "^0.6.1",
433433
"tmp": "0.2.1",
434434
"ua-parser-js": "^0.7.23",

‎test/client/karma.conf.js

+11-26
Original file line numberDiff line numberDiff line change
@@ -14,35 +14,20 @@ const launchers = {
1414
browser: 'firefox',
1515
os: 'Windows',
1616
os_version: '10'
17-
}
17+
},
1818
// bs_safari: {
1919
// base: 'BrowserStack',
20-
// browser: 'safari',
21-
// browser_version: '9.0',
22-
// os_version: 'El Capitan',
23-
// os: 'OS X'
24-
// },
25-
// bs_ie_11: {
26-
// base: 'BrowserStack',
27-
// browser: 'ie',
28-
// browser_version: '11.0',
29-
// os: 'Windows',
30-
// os_version: '10'
31-
// },
32-
// bs_ie_10: {
33-
// base: 'BrowserStack',
34-
// browser: 'ie',
35-
// browser_version: '10.0',
36-
// os: 'Windows',
37-
// os_version: '8'
20+
// browser: 'Safari',
21+
// os: 'OS X',
22+
// os_version: 'Big Sur'
3823
// },
39-
// bs_ie_9: {
40-
// base: 'BrowserStack',
41-
// browser: 'ie',
42-
// browser_version: '9.0',
43-
// os: 'Windows',
44-
// os_version: '7'
45-
// }
24+
bs_ie: {
25+
base: 'BrowserStack',
26+
browser: 'IE',
27+
browser_version: '11.0',
28+
os: 'Windows',
29+
os_version: '10'
30+
}
4631
}
4732

4833
// Verify the install. This will run async but that's ok we'll see the log.

‎test/client/karma.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe('Karma', function () {
1717
beforeEach(function () {
1818
mockTestStatus = ''
1919
updater = {
20-
updateTestStatus: (s) => {
20+
updateTestStatus: function (s) {
2121
mockTestStatus = s
2222
}
2323
}
@@ -454,7 +454,7 @@ describe('Karma', function () {
454454
clock.tick(500)
455455

456456
ck.complete()
457-
setTimeout(() => {
457+
setTimeout(function () {
458458
assert(windowLocation.href === 'http://return.com')
459459
done()
460460
}, 5)

0 commit comments

Comments
 (0)
Please sign in to comment.