fix(server): replace optimist on yargs lib (#3451)

fix #2473

Author: anthony-redFox

lib/cli.js

@@ -2,7 +2,7 @@
 
 const path = require('path')
 const assert = require('assert')
-const optimist = require('optimist')
+const yargs = require('yargs')
 const fs = require('graceful-fs')
 
 const Server = require('./server')
@@ -11,7 +11,7 @@ const constant = require('./constants')
 
 function processArgs (argv, options, fs, path) {
   if (argv.help) {
-    console.log(optimist.help())
+    console.log(yargs.help())
     process.exit(0)
   }
 
@@ -152,7 +152,7 @@ function argsBeforeDoubleDash (argv) {
 }
 
 function describeShared () {
-  optimist
+  yargs
     .usage('Karma - Spectacular Test Runner for JavaScript.\n\n' +
       'Usage:\n' +
       '  $0 <command>\n\n' +
@@ -167,7 +167,7 @@ function describeShared () {
 }
 
 function describeInit () {
-  optimist
+  yargs
     .usage('Karma - Spectacular Test Runner for JavaScript.\n\n' +
       'INIT - Initialize a config file.\n\n' +
       'Usage:\n' +
@@ -179,7 +179,7 @@ function describeInit () {
 }
 
 function describeStart () {
-  optimist
+  yargs
     .usage('Karma - Spectacular Test Runner for JavaScript.\n\n' +
       'START - Start the server / do a single run.\n\n' +
       'Usage:\n' +
@@ -205,7 +205,7 @@ function describeStart () {
 }
 
 function describeRun () {
-  optimist
+  yargs
     .usage('Karma - Spectacular Test Runner for JavaScript.\n\n' +
       'RUN - Run the tests (requires running server).\n\n' +
       'Usage:\n' +
@@ -221,7 +221,7 @@ function describeRun () {
 }
 
 function describeStop () {
-  optimist
+  yargs
     .usage('Karma - Spectacular Test Runner for JavaScript.\n\n' +
       'STOP - Stop the server (requires running server).\n\n' +
       'Usage:\n' +
@@ -232,7 +232,7 @@ function describeStop () {
 }
 
 function describeCompletion () {
-  optimist
+  yargs
     .usage('Karma - Spectacular Test Runner for JavaScript.\n\n' +
       'COMPLETION - Bash/ZSH completion for karma.\n\n' +
       'Installation:\n' +
@@ -245,7 +245,7 @@ function printRunnerProgress (data) {
 }
 
 exports.process = function () {
-  const argv = optimist.parse(argsBeforeDoubleDash(process.argv.slice(2)))
+  const argv = yargs.parse(argsBeforeDoubleDash(process.argv.slice(2)))
   const options = {
     cmd: argv._.shift()
   }
@@ -280,7 +280,7 @@ exports.process = function () {
       } else {
         console.error('Unknown command "' + options.cmd + '".')
       }
-      optimist.showHelp()
+      yargs.showHelp()
       process.exit(1)
   }
 

package-lock.json

@@ -406,30 +406,30 @@
     "log4js": "^4.0.0",
     "mime": "^2.3.1",
     "minimatch": "^3.0.2",
-    "optimist": "^0.6.1",
     "qjobs": "^1.1.4",
     "range-parser": "^1.2.0",
     "rimraf": "^2.6.0",
     "socket.io": "2.1.1",
     "source-map": "^0.6.1",
     "tmp": "0.0.33",
-    "ua-parser-js": "0.7.21"
+    "ua-parser-js": "0.7.21",
+    "yargs": "^15.3.1"
   },
   "devDependencies": {
+    "@commitlint/cli": "^8.3.4",
+    "@commitlint/config-conventional": "^8.3.4",
     "browserify": "^16.2.3",
     "chai": "^4.2.0",
     "chai-as-promised": "^7.1.1",
     "chai-subset": "^1.2.2",
-    "@commitlint/cli": "^8.3.4",
-    "@commitlint/config-conventional": "^8.3.4",
     "cucumber": "^3.1.0",
     "eslint": "^5.16.0",
     "eslint-config-standard": "^12.0.0",
     "eslint-plugin-import": "^2.17.2",
     "eslint-plugin-node": "^9.0.1",
     "eslint-plugin-promise": "^4.1.1",
     "eslint-plugin-standard": "^4.0.0",
-    "grunt": "^1.0.4",
+    "grunt": "^1.1.0",
     "grunt-auto-release": "^0.0.7",
     "grunt-browserify": "^5.0.0",
     "grunt-bump": "^0.8.0",

package.json

@@ -1,6 +1,6 @@
 'use strict'
 
-const optimist = require('optimist')
+const yargs = require('yargs')
 const path = require('path')
 const mocks = require('mocks')
 
@@ -34,7 +34,7 @@ describe('cli', () => {
   }
 
   const processArgs = (args, opts) => {
-    const argv = optimist.parse(args)
+    const argv = yargs.parse(args)
     return e.processArgs(argv, opts || {}, fsMock, pathMock)
   }
 
@@ -62,7 +62,7 @@ describe('cli', () => {
 
   describe('processArgs', () => {
     it('should override if multiple options given', () => {
-      // optimist parses --port 123 --port 456 as port = [123, 456] which makes no sense
+      // yargs parses --port 123 --port 456 as port = [123, 456] which makes no sense
       const options = processArgs(['some.conf', '--port', '12', '--log-level', 'info', '--port', '34', '--log-level', 'debug'])
 
       expect(options.port).to.equal(34)