fix(client): flush resultsBuffer on engine upgrade

[tbhartman]

Fixes #3211

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[tbhartman]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

[karmarunnerbot]

❌ Build karma 220 failed (commit e47af6bb53 by @tbhartman)

[AppVeyorBot]

❌ Build karma 2618 failed (commit e47af6bb53 by @tbhartman)

[karmarunnerbot]

❌ Build karma 219 failed (commit e47af6bb53 by @tbhartman)

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[AppVeyorBot]

✅ Build karma 2619 completed (commit d012a9f285 by @devoto13)

[karmarunnerbot]

✅ Build karma 221 completed (commit d012a9f285 by @devoto13)

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[karmarunnerbot]

✅ Build karma 220 completed (commit d012a9f285 by @devoto13)

[AppVeyorBot]

✅ Build karma 2620 completed (commit 51435215c1 by @tbhartman)

[karmarunnerbot]

✅ Build karma 222 completed (commit 51435215c1 by @tbhartman)

[devoto13]

Thanks!

I've added a check to make broken tests pass. The fix for that issue is available in #3486.

The reasoning for the fix is in #3211 (comment).

@johnjbarton I think this PR should be good to merge now.

[karmarunnerbot]

✅ Build karma 221 completed (commit 51435215c1 by @tbhartman)

[johnjbarton]

The test for this change is in #3487

[karmarunnerbot]

🎉 This PR is included in version 5.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀