Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-list): do not define fs.statAsync #3467

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

matz3
Copy link
Contributor

@matz3 matz3 commented Apr 9, 2020

Defining fs.statAsync affects other modules such as bluebird which
throws an error because of the 'Async'-suffix:

Cannot promisify an API that has normal methods with 'Async'-suffix
See http://goo.gl/MqrFmX

Fixes: #3466

Defining fs.statAsync affects other modules such as bluebird which
throws an error because of the 'Async'-suffix:

> Cannot promisify an API that has normal methods with 'Async'-suffix
> See http://goo.gl/MqrFmX

Fixes: karma-runner#3466
@AppVeyorBot
Copy link

Build karma 2575 completed (commit 3419c2ebd1 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 176 completed (commit 3419c2ebd1 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 177 completed (commit 3419c2ebd1 by @matz3)

Copy link
Collaborator

@devoto13 devoto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes better, thanks

@johnjbarton
Copy link
Contributor

retry

@johnjbarton johnjbarton closed this Apr 9, 2020
@johnjbarton johnjbarton reopened this Apr 9, 2020
@karmarunnerbot
Copy link
Member

Build karma 182 completed (commit 26e7b27a80 by @matz3)

@karmarunnerbot
Copy link
Member

Build karma 181 completed (commit 26e7b27a80 by @matz3)

@AppVeyorBot
Copy link

Build karma 2580 completed (commit 26e7b27a80 by @matz3)

@johnjbarton
Copy link
Contributor

Ok so now the travis integration point is broken. I will force this PR, and see if we get a release.

@johnjbarton johnjbarton merged commit 55a59e7 into karma-runner:master Apr 9, 2020
karmarunnerbot pushed a commit that referenced this pull request Apr 10, 2020
## [5.0.1](v5.0.0...v5.0.1) (2020-04-10)

### Bug Fixes

* **file-list:** do not define fs.statAsync ([#3467](#3467)) ([55a59e7](55a59e7))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@matz3 matz3 deleted the fix-fs-statAsync branch April 15, 2020 09:34
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
Defining fs.statAsync affects other modules such as bluebird which
throws an error because of the 'Async'-suffix:

> Cannot promisify an API that has normal methods with 'Async'-suffix
> See http://goo.gl/MqrFmX

Fixes: karma-runner#3466
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
## [5.0.1](karma-runner/karma@v5.0.0...v5.0.1) (2020-04-10)

### Bug Fixes

* **file-list:** do not define fs.statAsync ([karma-runner#3467](karma-runner#3467)) ([55a59e7](karma-runner@55a59e7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.statAsync should not be defined globally
5 participants