Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical vulnerability: Insufficient validation when decoding a Socket.IO packet #3823

Open
salomedo opened this issue Oct 31, 2022 · 10 comments

Comments

@salomedo
Copy link

Hello,

We are currently facing a critical vulnerability in our project that depends on karma.
GHSA-qm95-pgcg-qqfq

Steps to reproduce:
npm install
npm audit

Console message:

├─ socket.io-parser: 4.0.4                                                                                                                                 
│  ├─ Issue: Insufficient validation when decoding a Socket.IO packet                                                                                      
│  ├─ URL: https://github.com/advisories/GHSA-qm95-pgcg-qqfq                                                                                               
│  ├─ Severity: critical                                                                                                                                   
│  ├─ Vulnerable Versions:                                                                                                                           
│  ├─ Patched Versions: >=4.0.5                                                                                                                            
│  ├─ Via: karma, karma-htmlfile-reporter, karma-jasmine-html-reporter                                                                                     
│  └─ Recommendation: Upgrade to version 4.0.5 or later   

Thank you in advance.

@johnbumgardner
Copy link

yeah experienced the same thing.

@dep
Copy link

dep commented Nov 1, 2022

I've tried updating my Karma stack to 6.4.1 but a few of my Karma suites are halting/failing to complete. When I view in the browser, I see pending localhost/socket-io requests that never complete, they just restart after 30 seconds. Feels awfully related to either this dependency or socket.io-parser.

image

@johnbumgardner
Copy link

I've tried updating my Karma stack to 6.4.1 but a few of my Karma suites are halting/failing to complete. When I view in the browser, I see pending localhost/socket-io requests that never complete, they just restart after 30 seconds. Feels awfully related to either this dependency or socket.io-parser.

image

6.4.1 is using the vulnerable socket.io

i made a PR bumping it and waiting on it to get reviewed.

#3825

@dep
Copy link

dep commented Nov 2, 2022

I tried adding these two resolutions along with 6.4.1 but ran into the same problem.

"resolutions": {
    ...
    "**/socket.io": "4.5.2",
    "**/socket.io-parser": "4.2.1",
    ...
}

@amanyzohair
Copy link

I'm experiencing the same problem

@dep
Copy link

dep commented Nov 7, 2022

Any timeline on getting this PR merged?

@AllForNothing
Copy link

+1, waiting for the patch version...

@LucasLopesr
Copy link

+1, waiting for the patch version...

@efogarasi
Copy link

+1, we are also waiting for the patch version...

@amanyzohair
Copy link

+1, waiting for the patch version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants