Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delaying execution..." also happens in e2e tests #534

Closed
staunsholm opened this issue May 6, 2013 · 4 comments
Closed

"Delaying execution..." also happens in e2e tests #534

staunsholm opened this issue May 6, 2013 · 4 comments

Comments

@staunsholm
Copy link

Looks like sort of the same issue as in:

#411

only this is with e2e tests.

Tests run fine first time around, second time it just hangs with this message:
INFO [karma]: Delaying execution, these browsers are not ready: Chrome 26.0 (Mac)

Reloading the Karma tab in Chrome, disconnects, reconnects and reruns the tests without a problem.

According to the console, no errors happen during or after the first run.

@vojtajina
Copy link
Contributor

For some reason, the adapter does not report complete(). Can you try basic/empty e2e test (for instance the one from https://github.com/karma-runner/karma/tree/master/test/e2e/angular-scenario), does it work for you ? If so, try to trace what is causing the troubles, eg. which test.

@lmessinger
Copy link

@staunsholm it seems that the E2E runner ('scenario adapter') watches all outgoing requests - for example, API request for JSON data. It will know it can continue running by waiting for ALL the responses to be back. But this could also cause issues in tests: if a certain request is hanging (for example, if there's no such product id), the test will hang. That could cause hours of debugging, so be aware. This last note was written from personal experience.

@vojtajina
Copy link
Contributor

@lmessinger you are correct. However, a hanging request should eventually get resolved (fail/success). We might also provide a timeout for this kind of stuff. This "waiting for finishing all async stuff" has other problems with stuff like interval updates (eg. you are updating something each second - that typically means a constant setTimeout, which would never resolve; or if you have a long timeout, maybe show a status message for 20 secs, we don't wanna wait for that during the test).

Please file an issue at Protractor https://github.com/juliemr/protractor/issues to make sure it does support these. Protractor can already mock out services from the test, which should help to solve these issues - ex. mock out the timeout service etc...

@vojtajina
Copy link
Contributor

@staunsholm does any of the previously mentioned help you?

I'm closing this issue, please re-open if you still having the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants