Translate date-fns and Quasar into Luxembourgish and include them

[dwaxweiler]

When I switch the language to Luxembourgish, the German locale is used for date formatting in the following pages:

• Wall
• Feedback
• Members
• History
• Issues
• Place: pickups, wall, feedback, history

The Luxembourgish locale is used on the following pages:

• Pickups
• Applications
• Place: manage pickups

Both lists are non-exhaustive; For instance, I have not checked the offer feature.

I assume that a third-party library is used for date formatting, but I have not checked which one.

[nicksellen]

Indeed! We use German there, as the library is not translated into Luxembourgish.

• here is the bit in our code where we make it use German
• the date library we use is called date-fns (list of languages is on the front page) and it has a nice guide for adding another language

Also, our UI library (Quasar) also has a language selection, and they also don't have Lëtzebuergesch so we use German there too (they have these languages available)... but probably what you're seeing is from date-fns.

We could collaborate to get Lëtzebuergesch added to date-fns (and maybe Quasar too) if you're up for it?

Edit: I just read your message properly, and you say it's correct on some pages, my guess would be that for those formats it's where the correct format matches the German one?

[dwaxweiler]

Thanks for pointing me to the wiring and the libraries used! German as an alternative has been a wise choice as both languages are quite close. This is also the reason why it looks correct on some pages.

Sure, I am up for translating both libraries. I will look into this later today.

[dwaxweiler]

I have created a PR for the date-fns library: date-fns/date-fns#1900

[nicksellen]

Amazing! Good job 👍

I had a look at another recent language addition to see how long it might take until it gets merged - that one was 9 days until merged to master. I guess it'll then need to have a new release from that too. Let's see how it goes.

[dwaxweiler]

Thanks! I will let you know about its progress and will translate Quasar in the next days too. I suggest to leave this issue open until we have included the updated version of both libraries.

[dwaxweiler]

@nicksellen I imagine we have both missed the presence of the Luxembourgish locale in the Quasar project when checking it briefly, but is already there! Could you have a look at my PR please?

[dwaxweiler]

@nicksellen Your guess of 9 days was correct! My PR on date-fns has been merged yesterday, accompanied with a new release. I have created another PR here just now to change the config.

[nicksellen]

Nice! I'll do a production deployment shortly to get it live...

[dwaxweiler]

Nice! I'll do a production deployment shortly to get it live...

To https://dev.karrot.world/ ?

[nicksellen]

Deployment to https://dev.karrot.world happens automatically after it's merged to master, production deployment is to https://karrot.world and has a confirmation button to press, which I pressed :) ... so it should all be live and active on both sites now.

[dwaxweiler]

Yeah, it is looking good! Thank you to both of you @tiltec and @nicksellen for reviewing and deploying this so fast!