Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming updates #3

Open
3 tasks
karthik opened this issue Apr 6, 2014 · 5 comments
Open
3 tasks

Upcoming updates #3

karthik opened this issue Apr 6, 2014 · 5 comments

Comments

@karthik
Copy link
Owner

karthik commented Apr 6, 2014

Based on discussions with Hadley, I'm going to rework the package to stop mimicking the same style as RColorBrewer.

  • I'll just add S3 methods to just plot any palette
  • Avoid using get
  • Add a whole slew of new palettes I've been painstakingly assembling (no longer from the tumblr)

If anyone has other suggestions, please add here. I'll leave this version as-is for RColorBrewer fans and bump up to version 2.

@jhollist
Copy link

Saw this after I sent my pull request.

Hmmm, may not make sense to add mine in given you have plans for new palettes...

@karthik
Copy link
Owner Author

karthik commented Jul 25, 2014

Thanks Jeff!
Ah, no worries. I'll review this PR next week and get back to you.

@jhollist
Copy link

Sounds good.

On Fri, Jul 25, 2014 at 12:31 PM, Karthik Ram notifications@github.com
wrote:

Thanks Jeff!
Ah, no worries. I'll review this PR next week and get back to you.


Reply to this email directly or view it on GitHub
#3 (comment).

Jeff W. Hollister
email: jeff.w.hollister@gmail.com
google voice: 401 326 2531
cell: 401 556 4087

@hadley
Copy link
Contributor

hadley commented Dec 6, 2014

https://github.com/hadley/wesanderson/tree/palette-list implements the first two - happy to turn it into a pull request

@karthik
Copy link
Owner Author

karthik commented Dec 8, 2014

@hadley I looked this over and it would be great to have as a PR. Please send along when you find some time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants