Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate new JSX transform benefits #9

Open
fs-c opened this issue Mar 6, 2021 · 0 comments · May be fixed by #13
Open

Emulate new JSX transform benefits #9

fs-c opened this issue Mar 6, 2021 · 0 comments · May be fixed by #13

Comments

@fs-c
Copy link
Contributor

fs-c commented Mar 6, 2021

I really like the new JSX transform because having a (deceivingly) "unused" import sit at the top of every file annoyed me to no end. I don't really care about the other changes of the new transform (see the post linked above) so the import is what I will focus on.

esbuild doesn't seem likely to introduce proper support for the new transform (evanw/esbuild#334) but they suggest either a plugin (which calls babel, so horrible performance) or to just use the inject option to inject the import into each file.

I'll submit a PR with the latter option in a second.

This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant