From e4838d28d7926fa63e5ea7b4ecb2be6744440036 Mon Sep 17 00:00:00 2001 From: Jan Kassens Date: Wed, 28 Sep 2022 20:53:36 -0400 Subject: [PATCH] Flow: remove max_workers setting This was added back in #17880 to make CI pass for an unrelated change. Submitting this PR to see if this is still needed to pass on CI. A lot of things have changed since. --- scripts/flow/config/flowconfig | 2 +- scripts/flow/createFlowConfigs.js | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/flow/config/flowconfig b/scripts/flow/config/flowconfig index bdd313dbd5dd9..0b94bb02fecba 100644 --- a/scripts/flow/config/flowconfig +++ b/scripts/flow/config/flowconfig @@ -39,7 +39,7 @@ untyped-type-import=error [options] -server.max_workers=4 +%CI_MAX_WORKERS% esproposal.class_static_fields=enable esproposal.class_instance_fields=enable esproposal.optional_chaining=enable diff --git a/scripts/flow/createFlowConfigs.js b/scripts/flow/createFlowConfigs.js index 62a54d11122af..a93cf1cef6020 100644 --- a/scripts/flow/createFlowConfigs.js +++ b/scripts/flow/createFlowConfigs.js @@ -45,6 +45,11 @@ function writeConfig(renderer, rendererInfo, isServerSupported) { }); const config = configTemplate + .replace( + '%CI_MAX_WORKERS%\n', + // On CI, we seem to need to limit workers. + process.env.CI ? 'server.max_workers=4\n' : '', + ) .replace( '%REACT_RENDERER_FLOW_OPTIONS%', `