Cannot build kata-runtime with go1.18

[zvonkok]

When building with go1.18,

error obtaining VCS status: exit status 128
	Use -buildvcs=false to disable VCS stamping.

To resolve this one needs to set --buildvcs=false , related golang issue: golang/go#51748.

Are we going to include any version control information into the binaries build?

Related release notes: https://tip.golang.org/doc/go1.18

We may add GOFLAGS to the Makefile to turn off or turn on such features coming with new golang versions.

$ export GOFLAGS=-buildvcs=false
$ sudo -E PATH=$PATH make install  
...
	qemu hypervisor path (QEMUPATH) : /usr/bin/qemu-system-x86_64
	cloud-hypervisor hypervisor path (CLHPATH) : /usr/bin/cloud-hypervisor
	firecracker hypervisor path (FCPATH) : /usr/bin/firecracker
	acrn hypervisor path (ACRNPATH) : /usr/bin/acrn-dm
	assets path (PKGDATADIR) : /usr/share/kata-containers
	shim path (PKGLIBEXECDIR) : /usr/libexec/kata-containers

     INSTALL  install-scripts
     INSTALL  install-completions
     INSTALL  install-configs
     INSTALL  install-configs
     INSTALL  install-bin
     INSTALL  install-containerd-shim-v2
     INSTALL  install-monitor

[liubin]

Hi @zvonkok thank you for this info.
Now we are using 1.17:

kata-containers/versions.yaml

Lines 251 to 262 in 79d93f1

	golang:
	description: "Google's 'go' language"
	notes: "'version' is the default minimum version used by this project."
	issue: "https://github.com/golang/go/issues/20676"
	uscan-url: >-
	https://github.com/golang/go/tags .*/go?([\d\.]+)\.tar\.gz
	version: "1.16.10"
	meta:
	description: |
	'newest-version' is the latest version known to work when
	building Kata
	newest-version: "1.17.3"

When upgrading golang, the build flag should be changed too as you said.

[liubin]

Go version issue kata-containers/tests#5134