Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement virtualization for list views #125

Open
Tracked by #93
, #110
...
zainfathoni opened this issue Jul 18, 2021 · 8 comments · May be fixed by #134
Open
Tracked by #93
, #110
...

Implement virtualization for list views #125

zainfathoni opened this issue Jul 18, 2021 · 8 comments · May be fixed by #134
Labels
bug Something isn't working enhancement New feature or request hacktoberfest Issues for Hacktoberfest
Projects
Kanban Board Prioritization
Milestone
Further Optimizat...

Comments

@zainfathoni
Copy link
Member

zainfathoni commented Jul 18, 2021 •
edited

Description

In provinces with a large number of contacts, the item rendering was delayed while scrolling due to a large number of HTML elements that need to be rendered by the browser.

WhatsApp.Video.2021-07-18.at.10.10.43.mp4

Expected Behaviour

There should be no blank screen rendered while scrolling the items.

If this is implemented correctly, the Lighthouse scores should have been much better than this:

Screenshot 2021-07-18 at 23 28 33

Additional Information

We can use react-window to implement the virtualization technique in the list.
@zainfathoni zainfathoni added the bug Something isn't working label Jul 18, 2021
@zainfathoni zainfathoni self-assigned this Jul 18, 2021
@zainfathoni zainfathoni added the enhancement New feature or request label Jul 18, 2021
@zainfathoni zainfathoni added this to To do in Kanban Board via automation Jul 18, 2021
@zainfathoni zainfathoni added this to Needs triage in Prioritization via automation Jul 18, 2021
@zainfathoni zainfathoni moved this from Needs triage to High priority in Prioritization Jul 18, 2021
@zainfathoni zainfathoni mentioned this issue Jul 18, 2021
Open
26 tasks
@suliskh
Copy link

suliskh commented Jul 18, 2021

Could I work on this, Mas?

@zainfathoni
Copy link
Member Author

Yes, of course. Thanks for the initiative!

Please go ahead. Don't forget to submit a Draft Pull Request soon to signal other contributors that you have started working on it. 😉

@zainfathoni zainfathoni mentioned this issue Jul 18, 2021
Open
12 tasks
@suliskh
Copy link

suliskh commented Jul 18, 2021 •
edited

Hi mas @zainfathoni, I am having a difficulty while trying to make a draft PR (pic attached).
I can successfully pull, but cant push to the origin.
Screen Shot 2021-07-18 at 12 04 52

What I have done:

  • Checked the ssh-key. It's matched.
  • Used https instead of ssh
  • Recloned the repo

Nothing works for me. Also, I have no problem push/pull to another repo. Would you help me with that? :sungkem:

@zainfathoni
Copy link
Member Author

zainfathoni commented Jul 18, 2021 •
edited

Hi Mas @suliskh, you can't push directly to this repository, because you don't have write permission to this repository.
What you (and all other contributors) should do is forking this repository into your own repository and submit a PR from your repository to this repository.

You can read more about Forking Projects here.

@andriawan could you please assist him if he has any further issues?

@andriawan
Copy link
Collaborator

Oke mas @zainfathoni ..

Please mention me if you have any issue with this mas @suliskh

@andriawan
Copy link
Collaborator

FYI mas @suliskh

image

@andriawan
Copy link
Collaborator

andriawan commented Jul 18, 2021 •
edited

after forking this repo, you will have copy of this repo on your account. you can start push branch on your copy of repo. github will inform you about PR for this original/upstream repo

cc @suliskh

image

@suliskh suliskh linked a pull request Jul 18, 2021 that will close this issue
Draft
2 tasks
@suliskh
Copy link

suliskh commented Jul 20, 2021 •
edited

Halo mas @zainfathoni and mas @andriawan, thank you for guiding me and I've managed to make a PR(#134) with some caveat that I can't fix. Would you mind looking into that? Please see the "Caveat" section. Thank you :sungkem:

@zainfathoni zainfathoni mentioned this issue Jul 20, 2021
Open
@resir014 resir014 mentioned this issue Jul 25, 2021
Open
6 tasks
@zainfathoni zainfathoni removed their assignment Aug 21, 2021
@zainfathoni zainfathoni added the hacktoberfest Issues for Hacktoberfest label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request hacktoberfest Issues for Hacktoberfest
Projects
Kanban Board
To do
Prioritization
High priority
Milestone
Further Optimizations
Development

Successfully merging a pull request may close this issue.

Add virtualization in province contacts page suliskh/wargabantuwarga.com
3 participants
@zainfathoni @andriawan @suliskh