Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n reference to root causes memory leak #1044

Closed
lzxb opened this issue Nov 10, 2020 · 3 comments
Closed

i18n reference to root causes memory leak #1044

lzxb opened this issue Nov 10, 2020 · 3 comments
Labels
help wanted Extra attention is needed Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes

Comments

@lzxb
Copy link
Contributor

lzxb commented Nov 10, 2020 •
edited

vue & vue-i18n version

ex: 2.6.12, 8.22.1

Reproduction Link

Steps to reproduce

image

What is Expected?

i18n.$root in root beforeDestroy hook remove it.
image

What is actually happening?

image

When the root instance is destroyed, the i18n object also keeps a reference to the root, which makes it impossible to be recycled by memory
@lzxb
Copy link
Contributor Author

lzxb commented Nov 10, 2020

The existing architecture will lead to cross reference when multiple Vue root instances are used

@kazupon kazupon added help wanted Extra attention is needed Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes labels Nov 21, 2020
@kazupon
Copy link
Owner

kazupon commented Nov 21, 2020

Thank you for your reporting!
good catch!
welcome contribution!

lzxb added a commit to lzxb/vue-i18n that referenced this issue Mar 21, 2021
@lzxb
fix: i18n reference to root causes memory leak (kazupon#1044)
0534422
@lzxb lzxb mentioned this issue Mar 21, 2021
Merged
kazupon pushed a commit that referenced this issue Mar 22, 2021
@lzxb
fix: i18n reference to root causes memory leak (#1044) (#1151)
ca4e11a
@kazupon
Copy link
Owner

kazupon commented Mar 23, 2021

close (release v8.24.2)
https://github.com/kazupon/vue-i18n/releases/tag/v8.24.2

@kazupon kazupon closed this as completed Mar 23, 2021
@PeterAlfredLee PeterAlfredLee mentioned this issue Apr 23, 2021
Closed
kazupon added a commit that referenced this issue Apr 28, 2021
@kazupon
Revert "fix: i18n reference to root causes memory leak (#1044) (#1151)"
331dbd6 
This reverts commit ca4e11a.
kazupon added a commit that referenced this issue Apr 28, 2021
@kazupon
Revert "fix: i18n reference to root causes memory leak (#1044) (#1151)…
2913ca1 
…" (#1192)

This reverts commit ca4e11a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kazupon @lzxb