Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom modifiers are broken #1308

Closed
Leemonn opened this issue Jul 8, 2021 · 3 comments
Closed

Custom modifiers are broken #1308

Leemonn opened this issue Jul 8, 2021 · 3 comments
Labels
Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes

Comments

@Leemonn
Copy link

Leemonn commented Jul 8, 2021

Module versions (please complete the following information):

  • vue: 2.4.2
  • vue-i18n: 8.24.5

Reproduction Link
https://stackblitz.com/edit/vue-i18n-6abnwm?file=plugins/i18n.js

To Reproduce
Steps to reproduce the behavior:
ex:

  1. Use an integrated modifier like upper or capitalize.
  2. See that it works
  3. Add a custom modifier
  4. Use the custom modifier instead of the integrated one.
  5. See that the string is not working.

Expected behavior
If the custom modifier is declared then it should apply the modifier and it should show the string.

@Leemonn Leemonn added the Status: Review Needed Request for review comments label Jul 8, 2021
@Leemonn
Copy link
Author

Leemonn commented Jul 12, 2021

Bump

@kazupon kazupon added Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes and removed Status: Review Needed Request for review comments labels Aug 3, 2021
@DZ-study
Copy link

modifiers: { snakeCase: (str) => str.split(' ').join('-') },
snakeCase转换成snakecase,又可以了。。

@kazupon
Copy link
Owner

kazupon commented Jun 20, 2022

fixed with #1512

@kazupon kazupon closed this as completed Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: PR Welcome Welcome to Pull Request Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

3 participants