Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: A Vue SFC with a <i18n> block + an i18n configuration in the component options is not working #996

Closed
ferencbeutel4711 opened this issue Sep 9, 2020 · 0 comments
Closed

[Bug]: A Vue SFC with a <i18n> block + an i18n configuration in the component options is not working #996

ferencbeutel4711 opened this issue Sep 9, 2020 · 0 comments

Comments

@ferencbeutel4711
Copy link
Contributor

ferencbeutel4711 commented Sep 9, 2020 •
edited

Hi, if a consumer is using a vue SFC, there is currently a logic bug present in the library which prevents using an <i18n> block in the SFC in addition to the i18n configuration from the components configuration. This also has implications for mixin support since this also affects a SFC component with an <i18n> block which includes a mixin which has the i18n configuration in the mixins options.

My proposal to fix is trivial, merge the <i18n> block and the i18n component configuration instead of overriding the later with the former:

#995
ferencbeutel4711 added a commit to ferencbeutel4711/vue-i18n that referenced this issue Sep 11, 2020
@ferencbeutel4711
Fix kazupon#996 for plain objects aswell
f05f88f
ferencbeutel4711 pushed a commit to ferencbeutel4711/vue-i18n that referenced this issue Sep 11, 2020
Fix test for kazupon#996
efe0194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ferencbeutel4711