Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace is likely modified somewhere without a DeepCopy #2841

Open
ncdc opened this issue Feb 22, 2023 · 3 comments
Open

Namespace is likely modified somewhere without a DeepCopy #2841

ncdc opened this issue Feb 22, 2023 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ncdc
Copy link
Member

ncdc commented Feb 22, 2023

From https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-kcp-dev-kcp-main-e2e-shared-periodic/1626703272859406336, got a concurrent map iterate + write when trying to deep copy a namespace (specifically, its annotations). It seems like we are probably modifying a namespace from an informer cache without having made a deep copy first.
@ncdc ncdc added the kind/bug Categorizes issue or PR as related to a bug. label Feb 22, 2023
@ncdc
Copy link
Member Author

ncdc commented Feb 28, 2023

This failure was in a private kcp server, which doesn't have the env propagated to enable the cache mutation detector. Need to fix that.

@kcp-ci-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
After a furter 30 days, they will turn rotten.
Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kcp-ci-bot kcp-ci-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2024
@kcp-ci-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kcp-ci-bot kcp-ci-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
kcp
Status: Next
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ncdc @kcp-ci-bot