Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Data.Generics.Labels into generic-lens-labels #102

Open
phadej opened this issue Oct 21, 2019 · 2 comments
Open

Split Data.Generics.Labels into generic-lens-labels #102

phadej opened this issue Oct 21, 2019 · 2 comments
Milestone

Comments

@phadej
Copy link
Collaborator

phadej commented Oct 21, 2019

While looking at generic-optics stuff (where generic-optics cannot have IsLabel instance ,as opticsdefine one itself), it occurred to me:

As we are splitting packages, let's split Data.Generics.Labels out of generic-lens into own package, e.g. generic-lens-labels.

Then it would be very easy to see if some library "accidentally" uses the IsLabel ((->) ...), as the fact is visible from package dependency graph.

@kcsongor kcsongor added this to the 2.1.0.0 milestone Feb 12, 2020
@kcsongor
Copy link
Owner

In principle I agree with this idea. There is already a library with that name, https://hackage.haskell.org/package/generic-lens-labels which does exactly that, but it doesn't seem to be maintained and it's for an older version of generic-lens.

@duog, would you be open to transferring the maintainership of generic-lens-labels so we could keep it up to date with the upstream library?

@michaelpj
Copy link
Collaborator

We could move it into an additional public library, perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants