Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Github detection #233

Open
Lazerbeak12345 opened this issue Dec 11, 2022 · 0 comments
Open

Better Github detection #233

Lazerbeak12345 opened this issue Dec 11, 2022 · 0 comments

Comments

@Lazerbeak12345
Copy link

Is your feature request related to a problem? Please describe.
I use the ssh remote format for many of my cloned github repos.

An example of this format is:

git clone git@github.com:kefranabg/readme-md-generator.git

As you can see in this function below...

/**
* Check if repository is a Github repository
*
* @param {string} repositoryUrl
*/
const isGithubRepository = repositoryUrl =>
!isNil(repositoryUrl) && repositoryUrl.includes(GITHUB_URL)

Where GITHUB_URL is defined as

const GITHUB_URL = 'https://github.com/'

The check for if a local project is a github project clone only handles git-over-https.

Describe the solution you'd like
An expansion to treat git-over-ssh on the github url as the same as the equivalent git-over-https

Describe alternatives you've considered
Unsure.

Additional context
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@Lazerbeak12345 and others