Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to recognize and correct for false-positive and false-negatives #38

Open
davemasselink opened this issue Feb 11, 2020 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@davemasselink
Copy link
Contributor

The concept of a health check succeeding or failing is related to the final return value from the nested/imported Argo workflow.

This isn't always incredibly obvious and can lead to scenarios where the workflow doesn't behave as expected yet is still marked as succeeded. Similarly, even if the workflow behaves as expected, it may indicate a failure if a non-0 return code is used.

README documentation should be improved to highlight this and provide users with patterns/strategies to ensure that healthchecks are behaving as expected and building confidence in the usage of Active-Monitor.

@davemasselink davemasselink added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 11, 2020
@davemasselink davemasselink self-assigned this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant