Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for success/failure counts to be reset at user request or periodically #40

Open
davemasselink opened this issue Feb 11, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested

Comments

@davemasselink
Copy link
Contributor

Currently, the success and failure counts associated with each healthcheck will start at 0 when first registered and monotonically increase over the life of the healthcheck (or active-monitor controller).

This works alright, however, one downside of such an approach is that you need to know how long the healthcheck has been running in order to have any context for whether the counts are large or small.

Therefore, the aim of this ticket is to provide:

  • a mechanism for a user to "reset" the counts so that they will better understand what a non-0 failure count means, for instance OR
  • a new property in the spec which allows for the user to indicate how frequently the counts should be reset to 0 (this would allow for alerting if the failure count surpassed N within that time period) OR
  • an addl status property which would represent a moving average rate of success/fail over some unit time (ex: 4 successes/hr, 2 failures/day)

Open questions:

  • which approach to pursue
  • what unit to use as the default time duration, ex: hr, day (if 3rd approach above is pursued)
  • are there any better strategies which allow for counts to reliably be used in alerting logic
@davemasselink davemasselink added documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested labels Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant