feat: Introduce option for sorting deps in the same ordering as npm #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The option is `--npm-sort-ordering`, with the default value of `false`
|
I know that this is rather hacky, but I could not figure out another way to pass in an argument for the Also, how would I go about adding a unit test for this? |
keithamus
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks for the PR! I’d like us to avoid the use of flags. We should be able to infer the npm version from the package.json or the users environment variables. Configuration flags mean that different invocations result in different outputs and I want to avoid that as much as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--npm-sort-ordering, with the default value offalseresolves #234