Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download binaries like sharp #1022

Open
root-io opened this issue Jan 10, 2024 · 1 comment
Open

Download binaries like sharp #1022

root-io opened this issue Jan 10, 2024 · 1 comment

Comments

@root-io
Copy link

root-io commented Jan 10, 2024

I wish I could install bcrypt the way sharp does it: https://sharp.pixelplumbing.com/install#cross-platform

Example with npm: npm install --cpu=x64 --os=linux --libc=musl bcrypt


Edit: Sorry I was not clear enough about this improvement and I closed it because I found another alternative.

Let me explain:

I run Docker on a Apple silicon CPU (darwin arm64) with a linux container (arm64 musl) but my prod is linux x64 musl. That's 3 different os/arch/libc configuration.

I had issues installing your library and I think I'm not the only one and the easy fix is to install the javascript implementation alternative: bcryptjs but you take a hit on performance compared to your C++ implementation.

I ended up installing argon2 v0.40 which works well.

TL;DR: sharp (>=v0.33) and argon2 (>=v0.40) seem to have a better logic to install the right binaries.

@root-io root-io closed this as completed Jan 10, 2024
@recrsn
Copy link
Collaborator

recrsn commented Jan 11, 2024

This is an interesting approach, we can probably implement this in a future release

@recrsn recrsn reopened this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants