{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":371172777,"defaultBranch":"main","name":"column","ownerLogin":"kelindar","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-05-26T21:27:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/583116?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1697226792.0","currentOid":""},"activityList":{"items":[{"before":"82b9d596520e3946e8235df1dacc04b61059d3ed","after":null,"ref":"refs/heads/add-index","pushedAt":"2023-10-13T19:52:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"}},{"before":"330c5f455cab18211a5e5e009f191361e053377c","after":"0af9c372db72a60ff7f32bde50350c6fdbf3498c","ref":"refs/heads/main","pushedAt":"2023-10-13T19:52:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Return cursor index (#98)\n\nThis PR adds `Index()` function to the transaction, returning the\r\ncurrent cursor index.","shortMessageHtmlLink":"Return cursor index (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1942551670\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kelindar/column/issues/98\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kelindar/column/pull/98/hovercard\" href=\"https://github.com/kelindar/column/pull/98\">#98</a>)"}},{"before":null,"after":"82b9d596520e3946e8235df1dacc04b61059d3ed","ref":"refs/heads/add-index","pushedAt":"2023-10-13T19:49:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Return cursor index","shortMessageHtmlLink":"Return cursor index"}},{"before":"fb15ec4b8d21e3bbcca8329faa19ebd5663c7950","after":null,"ref":"refs/heads/fix-87","pushedAt":"2023-07-03T16:21:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"}},{"before":"f9e0f035ccbd155782ecc15593609019c74fa5a1","after":"330c5f455cab18211a5e5e009f191361e053377c","ref":"refs/heads/main","pushedAt":"2023-07-03T16:21:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Fix withValue on record column type (#92)\n\nThis PR fixes issue #87 where `WithValue()` wasn't unmarshaling the\r\nrecord.","shortMessageHtmlLink":"Fix withValue on record column type (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1786474375\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kelindar/column/issues/92\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kelindar/column/pull/92/hovercard\" href=\"https://github.com/kelindar/column/pull/92\">#92</a>)"}},{"before":"182e931ff954dd5daf5354441b9ed6c3762db31f","after":"fb15ec4b8d21e3bbcca8329faa19ebd5663c7950","ref":"refs/heads/fix-87","pushedAt":"2023-07-03T16:20:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"coverage","shortMessageHtmlLink":"coverage"}},{"before":null,"after":"182e931ff954dd5daf5354441b9ed6c3762db31f","ref":"refs/heads/fix-87","pushedAt":"2023-07-03T16:12:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Fix withValue on record column type","shortMessageHtmlLink":"Fix withValue on record column type"}},{"before":"25fcf931c5222536cad3a1f73fda4bc1922ed043","after":null,"ref":"refs/heads/fix-89","pushedAt":"2023-07-02T13:04:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"}},{"before":"583d3517603931096cbac38c57c8da0e219be31f","after":"f9e0f035ccbd155782ecc15593609019c74fa5a1","ref":"refs/heads/main","pushedAt":"2023-07-02T13:04:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Fix creation of columns post insert (#90)\n\nThis fixes issue #89 which was due to an improperly initialized capacity\r\nfor new columns, occurring when inserting large number of rows that\r\nexceed initial capacity and then creating a column. The initial capacity\r\nwas set, not the current collection capacity, resulting in an incorrect\r\nnumber passed to `Grow()` method.","shortMessageHtmlLink":"Fix creation of columns post insert (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1784569247\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kelindar/column/issues/90\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kelindar/column/pull/90/hovercard\" href=\"https://github.com/kelindar/column/pull/90\">#90</a>)"}},{"before":"66614e0914403808382974583dc244f084d274a0","after":null,"ref":"refs/heads/test-large","pushedAt":"2023-07-02T13:04:17.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"}},{"before":"9ba467608b1844e2de0fb0f4c5f8eda50da401e3","after":"583d3517603931096cbac38c57c8da0e219be31f","ref":"refs/heads/main","pushedAt":"2023-07-02T13:04:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Simplify large snapshot test (#91)","shortMessageHtmlLink":"Simplify large snapshot test (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1784634831\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kelindar/column/issues/91\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kelindar/column/pull/91/hovercard\" href=\"https://github.com/kelindar/column/pull/91\">#91</a>)"}},{"before":null,"after":"66614e0914403808382974583dc244f084d274a0","ref":"refs/heads/test-large","pushedAt":"2023-07-02T13:00:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Simplify large snapshot test","shortMessageHtmlLink":"Simplify large snapshot test"}},{"before":null,"after":"25fcf931c5222536cad3a1f73fda4bc1922ed043","ref":"refs/heads/fix-89","pushedAt":"2023-07-02T10:23:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Fix creation of columns post insert","shortMessageHtmlLink":"Fix creation of columns post insert"}},{"before":"fd7111ffebe61cf8b2ab6b18d983d191bcd7ad58","after":"9ba467608b1844e2de0fb0f4c5f8eda50da401e3","ref":"refs/heads/main","pushedAt":"2023-07-02T09:38:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"kelindar","name":"Roman Atachiants","path":"/kelindar","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/583116?s=80&v=4"},"commit":{"message":"Fixed index out of range issue when loading large snapshot (#88)\n\nI recently found an issue when trying to load a snapshot created with a\r\nlarge number of rows (in my case 10 million).\r\nIt would result in an index out of range panic. I was able to reproduce\r\nthis in the unit tests with around 3 million players.\r\n\r\n```\r\nRunning tool: /usr/local/go/bin/go test -timeout 30s -run ^TestLargeSnapshot$ github.com/kelindar/column\r\n\r\n--- FAIL: TestLargeSnapshot (4.20s)\r\npanic: runtime error: index out of range [128] with length 128 [recovered]\r\n\tpanic: runtime error: index out of range [128] with length 128\r\n\r\ngoroutine 4 [running]:\r\ntesting.tRunner.func1.2({0x1053a25c0, 0x14059d74930})\r\n\t/usr/local/go/src/testing/testing.go:1389 +0x1c8\r\ntesting.tRunner.func1()\r\n\t/usr/local/go/src/testing/testing.go:1392 +0x384\r\npanic({0x1053a25c0, 0x14059d74930})\r\n\t/usr/local/go/src/runtime/panic.go:838 +0x204\r\ngithub.com/kelindar/column.(*Collection).readState.func1.1(0x14010b50090)\r\n\t/Users/sgosiaco/repos/column/snapshot.go:188 +0x274\r\ngithub.com/kelindar/column.(*Collection).Query(0x1400012c370, 0x1400005bd18)\r\n\t/Users/sgosiaco/repos/column/collection.go:354 +0x48\r\ngithub.com/kelindar/column.(*Collection).readState.func1(0x1400005bd88?, 0x105250968?)\r\n\t/Users/sgosiaco/repos/column/snapshot.go:184 +0x78\r\ngithub.com/kelindar/iostream.(*Reader).ReadRange(0x1402a07f020, 0x1400010fe10)\r\n\t/Users/sgosiaco/go/pkg/mod/github.com/kelindar/iostream@v1.3.0/reader.go:227 +0x8c\r\ngithub.com/kelindar/column.(*Collection).readState(0x1400012c370, {0x1053c3380?, 0x14000163900?})\r\n\t/Users/sgosiaco/repos/column/snapshot.go:183 +0x1d4\r\ngithub.com/kelindar/column.(*Collection).Restore(0x1400012c370, {0x1053c3080, 0x140001014a0})\r\n\t/Users/sgosiaco/repos/column/snapshot.go:44 +0x54\r\ngithub.com/kelindar/column.TestLargeSnapshot(0x140001151e0)\r\n\t/Users/sgosiaco/repos/column/snapshot_test.go:229 +0x174\r\ntesting.tRunner(0x140001151e0, 0x1053bf558)\r\n\t/usr/local/go/src/testing/testing.go:1439 +0x110\r\ncreated by testing.(*T).Run\r\n\t/usr/local/go/src/testing/testing.go:1486 +0x300\r\nFAIL\tgithub.com/kelindar/column\t4.339s\r\nFAIL\r\n```\r\n\r\nLooking at the code I saw that currently the maximum number of chunks\r\nable to be read is 128 due to the initialized size of the commits array.\r\nI've changed this to a map to allow for an unknown number of\r\nchunks/commits to be loaded since when saving the snapshot there doesn't\r\nseem to be a limit on the potential number of chunks that can be saved.","shortMessageHtmlLink":"Fixed index out of range issue when loading large snapshot (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1638601600\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kelindar/column/issues/88\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kelindar/column/pull/88/hovercard\" href=\"https://github.com/kelindar/column/pull/88\">#88</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADlq_5dgA","startCursor":null,"endCursor":null}},"title":"Activity · kelindar/column"}