Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.18 generics over "genny" #40

Open
lukasmalkmus opened this issue Dec 23, 2021 · 5 comments
Open

Use Go 1.18 generics over "genny" #40

lukasmalkmus opened this issue Dec 23, 2021 · 5 comments

Comments

@lukasmalkmus
Copy link

What is your take on Go 1.18 generics? Is that something you plan to support or implement? This would replace genny.

@kelindar
Copy link
Owner

Most definitely, I want to get rid of my genny fork and let compiler do its thing.

@lukasmalkmus
Copy link
Author

Do you mind me bringing up a branch and trying some stuff out over the holidays? Would love to play around with the beta and have a proper use case. Will also get some benchmarks. Even if it won't get accepted we might get some insights from it.

@lukasmalkmus
Copy link
Author

And I didn't know you were using your own genny fork. Might want to tag it using tools.go.

@kelindar
Copy link
Owner

Do you mind me bringing up a branch and trying some stuff out over the holidays? Would love to play around with the beta and have a proper use case. Will also get some benchmarks. Even if it won't get accepted we might get some insights from it.

Of course, would be great

@lukasmalkmus
Copy link
Author

I weren't able to implement anything usable yet, however, when using your genny fork I noticed it procudes different code than the one checked in manually. For example the casing is different and the generated code has "go:build ignore" tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants