Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible memory leak when taking a snapshot #85

Open
ami-m opened this issue Jan 15, 2023 · 2 comments
Open

possible memory leak when taking a snapshot #85

ami-m opened this issue Jan 15, 2023 · 2 comments

Comments

@ami-m
Copy link

ami-m commented Jan 15, 2023

I created a poc with column, it got hit with incoming data for a bout an hour, and after that I ran a loop that created a snapshot of the data once a minute.

I monitored the memory consumption and the memory usage jumped (and was not released) every time a snapshot was taken.

Other than closing the underlying writer, is there anything else I should have released?

if not, then I suspect a memory leak. pprof points the finger at the column.grow and s2.NewWriter as possible culprits.

@kelindar
Copy link
Owner

kelindar commented Jul 3, 2023

Will need to investigate this, do you have a test case?

@tanzegen
Copy link

Yes, I also have this problem, construct a loop to execute the snapshot, you will find that there is a fixed increase in memory, the Snapshot method creates an s2.NewWriter, does not seem to free it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants