Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create specific state for redis subscribe/unsubscribe #22

Closed
kendarorg opened this issue May 20, 2024 · 0 comments · Fixed by #26
Closed

Create specific state for redis subscribe/unsubscribe #22

kendarorg opened this issue May 20, 2024 · 0 comments · Fixed by #26
Labels
enhancement New feature or request in progress

Comments

@kendarorg
Copy link
Owner

kendarorg commented May 20, 2024 •
edited

The subscribe command put the connection in a state that accepts -only- incoming messages from server, and no messages but unsubscribe from client, would be good to make this thing explicit in the protocol definition like this:

        initialize(
            new ProtoStateWhile(
                    new ProtoStateSwitchCase(
                        new Resp3PullState(Resp3Message.class),
                        new ProtoStateSequence(
                                new Resp3Subscribe(Resp3Message.class), //added
                                new Resp3Unsubscribe(Resp3Message.class)))); //added
@kendarorg kendarorg added the enhancement New feature or request label May 20, 2024
@kendarorg kendarorg linked a pull request May 29, 2024 that will close this issue
[22] Add subscribe/unsubscribe state for resp3 #26
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[22] Add subscribe/unsubscribe state for resp3 kendarorg/the-protocol-master
1 participant
@kendarorg