Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the purpose of review groups #50

Open
phcoliveira opened this issue Jun 14, 2021 · 1 comment
Open

Explain the purpose of review groups #50

phcoliveira opened this issue Jun 14, 2021 · 1 comment

Comments

@phcoliveira
Copy link

phcoliveira commented Jun 14, 2021

Gretings!

I did not understand why would anyone use groups with the current implementation. For example, assume that I am devA.

# Single list
reviewers:
  - devA
  - devB
  - devC
  - devD
# Multiple groups
useReviewGroups: true
reviewGroups:
  fe:
    - devA
    - devB
  be:
    - devC
    - devD

In both cases, all the other 3 devs will be assigned.

I expected that, because I belong to team fe, only devB would be assigned. Instead, the result is the same of using a single list.

@ghost
Copy link

ghost commented Oct 20, 2022

Have the same question (issue). @kentaro-m, could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant