Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I use auto-assign bot with Github teams? #102

Open
mrlubos opened this issue Sep 5, 2019 · 13 comments
Open

Can I use auto-assign bot with Github teams? #102

mrlubos opened this issue Sep 5, 2019 · 13 comments

Comments

@mrlubos
Copy link
Contributor

mrlubos commented Sep 5, 2019

Hi! I am just exploring the auto-assign bot and I see I can configure groups to assign for reviews. However, these have to be defined in the config file. Since we already manage our groups in Github teams, would it be possible to reference only the Github team names in the config? Or is this an already existing feature? Thanks!

@kentaro-m
Copy link
Owner

kentaro-m commented Sep 12, 2019

Hi, @mrlubos! Thanks for waiting. The auto-assign bot is not supported to assign reviewers to the pull request using GitHub teams now. This topic has been discussed in #39 and #71.

Currently, It is hard to spend time on improving this tool. I have no plan to implement the feature. But improving features by creating the PR is always welcome.

@mrlubos
Copy link
Contributor Author

mrlubos commented Sep 12, 2019

Thanks for the reply @kentaro-m!

Is there any recommended workaround? For example, automatically generating the configuration file?

If not, we might look into creating a pull request. Would you have any pointers how to go about implementing this functionality within the auto-assign bot?

Thank you!

@okgolove
Copy link

+1

This would be a great feature!

@kwangsooshin
Copy link

+1

Awesome!

@stale
Copy link

stale bot commented Dec 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 24, 2019
@okgolove
Copy link

Do not close, please

@stale stale bot removed the wontfix This will not be worked on label Dec 26, 2019
@mrlubos
Copy link
Contributor Author

mrlubos commented Feb 27, 2020

Hi everyone! I created a pull request adding this functionality in #120, I would appreciate your feedback!

@matheusnascgomes
Copy link

matheusnascgomes commented Mar 14, 2020

Are you guys sure whether it's properly working? Because when i try, the log goes okay, but no reviewers are added to the reviewers list on the right side of the PR page.

@mrlubos @kentaro-m

@mrlubos
Copy link
Contributor Author

mrlubos commented Mar 15, 2020

Hey @matheusnascgomes, nice catch! 😃 Yes, it doesn't appear to be working for me either, I will need to look into why that is.

@adipatel
Copy link

+1

@igabesz
Copy link

igabesz commented Aug 18, 2020

I just tried this within our team and it does not work. I tried the @OrgName/team-name and the /team-name syntax in the auto_assign.yml file, neither one added the teams as reviewers. .github/auto_assign.yml:

addReviewers: true

reviewers:
    - /team-a
    - /team-b

numberOfReviewers: 0

We also use a .github/CODEOWNERS file, and it works fine, the owner team is added for review, and their approve is required for the merge.

*	@Org/team-c

@alexandrulesi
Copy link

+1

@vicsufer
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants