Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use babel traverse #156

Merged
merged 3 commits into from
Jun 14, 2020
Merged

Conversation

JoviDeCroock
Copy link
Contributor

Resolves: #121

This uses @babel/traverse rather than the stateful one

@JoviDeCroock JoviDeCroock marked this pull request as draft June 14, 2020 19:53
src/index.js Outdated
@@ -228,9 +229,10 @@ function applyMacros({
*
* See: https://github.com/kentcdodds/import-all.macro/issues/7
*/
state.file.scope.path.traverse({
console.log(state.file.ast);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this console log

Suggested change
console.log(state.file.ast);

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should've been formatted as well (no semicolons).

@JoviDeCroock
Copy link
Contributor Author

@kentcdodds sorry the pre-commit script seems to crash on windows 😅

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           97        98    +1     
  Branches        22        22           
=========================================
+ Hits            97        98    +1     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727459f...c74e247. Read the comment docs.

@kentcdodds
Copy link
Owner

Oh no! Sorry about that! If you could figure out why that would be a great help 😅

Thanks for this change!

@kentcdodds
Copy link
Owner

Is this PR still a draft or is it ready to be merged?

@JoviDeCroock JoviDeCroock marked this pull request as ready for review June 14, 2020 20:03
@JoviDeCroock
Copy link
Contributor Author

It seems good, I'll take a look what the issue is

@kentcdodds kentcdodds merged commit d5d44a6 into kentcdodds:master Jun 14, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @JoviDeCroock for code and tests

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @JoviDeCroock! 🎉

@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program visitor not being run for styled-components macro
2 participants