fix: type error in options parameter of mdxOptions #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 3 3
Lines 298 298
Branches 1 1
=======================================
Hits 272 272
Misses 26 26 ☔ View full report in Codecov by Sentry. |
|
@CottonCandyZ should this be rebased and then reviewed again? |
I rebased, and it seems there are no problems here. |
|
Nice, great! @kentcdodds, how does it look to you? If I understand correctly, I think this is an attempt to re-land #219 |
|
🎉 This PR is included in version 10.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What & Why:
#219 (comment)
It also contains a fix for the
remark-mdx-imagestype error.How:
Changed the type of the
optionparameter in themdxOptionsfunction. Updated the version of the dependencyremarkMdxImagesand thetsconfigto pass the tests.Checklist: