fix: processing invalid GITHUB_TOKEN #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check versionsSemantic/judgedVersions before processing * if we get a 404 code from github when using a token, make a repeat request without a token Closed: #139
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up.
|
kevincobain2000
approved these changes
Oct 1, 2023
|
That’s cool too. Thanks. |
|
Slightly corrected the error output |
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up.
|
* use prepared json to take a list of golang versions * use a single query to take the latest version of gobrew * now we don't need to use a token in requests
|
Now we use GitHub api only in exceptional cases and take only the latest release. As a result, we no longer need to use the token. |
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed: #139