Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add powershell install script #143

Conversation

lincolnthalles
Copy link
Contributor

This increses the ease of use for Windows users. The script downloads the latest gobrew version and setups all required environment variables in user scope.

GOPATH=$HOME\go
GOROOT=$HOME\.gobrew\current\go
PATH=$PATH;$HOME\go\bin;$HOME\.gobrew\bin;$HOME\.gobrew\current\bin

@kevincobain2000
Copy link
Owner

Thanks, and I have no way to test this. Kinda will have to take you on your word.

@lincolnthalles
Copy link
Contributor Author

Thanks, and I have no way to test this. Kinda will have to take you on your word.

I tested on Windows Sandbox, which spins up a clean virtual environment and it's fine.

With the last fixes, it's even possible to run this on Powershell for Linux.

@kevincobain2000
Copy link
Owner

Thanks and yea man. I am happy to merge, it doesn’t affect the core lib.
Will wait for the second Owners review @juev

Copy link
Collaborator

@juev juev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't verify the correctness of these changes because I don't have access to Windows. But the changes do not affect the current code and do not affect the performance of the application itself.

So I don't mind. :)

@kevincobain2000 kevincobain2000 merged commit 4aabed8 into kevincobain2000:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants