mode 1.21, tests and log msg txt #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up. |
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up. |
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up. |
juev
reviewed
Oct 15, 2023
gobrew_test.go
Outdated
| @@ -186,7 +186,8 @@ func TestDoNotUpgradeLatestVersion(t *testing.T) { | |||
|
|
|||
| gb := NewGoBrewDirectory(tempDir) | |||
|
|
|||
| binaryDir := filepath.Join(gb.installDir, "bin") | |||
| binaryDir := filepath.Join(gb.installDir, "bin", "gobrew") | |||
There was a problem hiding this comment.
I don’t understand much, why is binaryDir changing here? This is the directory where the file will be located.
Why does the location of the binary file change?
As a result we will have:
~/.gobrew/bin/gobrew/gobrew
This reverts commit 94cd26a.
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up. |
Summary CoverItUp: kevincobain2000/gobrew
Generated by Cover It Up. |
juev
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @juev
2 FYI items
FYI-1) I have added branch name
jsonto the Settings -> Protected Branches (force push allowed due to below)gobrew/.github/workflows/sync-release-tags.yml
Line 30 in 4aabed8
FYI-2) I have also removed some old branches that have been merged.