Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #145 by adding interactivity #147

Merged
merged 5 commits into from Nov 1, 2023
Merged

Conversation

kevincobain2000
Copy link
Owner

@kevincobain2000 kevincobain2000 commented Oct 31, 2023

Fixes #145

Kinda work in progress..

  • Get first impression
  • UT
  • manual testing for current working directory implementation
  • Update README.md
  • Add noninteractive option to the help menu?

About Colors

GREEN - on the dotted ... info
RED - When GO version not latest or version not same as go.mod
YELLOW - When GO mod version is not latest itself and for warning message before the prompt

A few screenshots below:

Basic Info and say no

Screenshot 2023-10-31 at 21 01 05

Basic info and say yes, show info again

Screenshot 2023-10-31 at 21 02 14

@kevincobain2000
Copy link
Owner Author

Hi @juev

The implementation for this was simple enough. Can you please give me your first review.
You should be able to test it on your local machine.
Thanks

@github-actions
Copy link

Summary CoverItUp: kevincobain2000/gobrew

Type master feature/gobrew
coverage 58.2 % 49.2 % -
go-binary-size 5.8k KB 5.9k KB +
go-mod-dependencies 29 29
go-sec-issues 6 6
build-time 5 sec 7 sec +
unit-test-run-time 68 sec 83 sec +

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

Copy link

github-actions bot commented Nov 1, 2023

Summary CoverItUp: kevincobain2000/gobrew

Type master feature/gobrew
coverage 58.2 % 47.7 % -
go-binary-size 5.8k KB 5.9k KB +
go-mod-dependencies 29 29
go-sec-issues 6 6
build-time 5 sec 6 sec +
unit-test-run-time 68 sec 80 sec +

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

Copy link

github-actions bot commented Nov 1, 2023

Summary CoverItUp: kevincobain2000/gobrew

Type master feature/gobrew
coverage 58.2 % 66.1 % +
go-binary-size 5.8k KB 5.9k KB +
go-mod-dependencies 29 28 -
go-sec-issues 6 6
build-time 5 sec 6 sec +
unit-test-run-time 68 sec 140 sec +

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

@kevincobain2000
Copy link
Owner Author

Ready for full review

gobrew.go Show resolved Hide resolved
…ile.

check for file existance first, otherwise set to None
Copy link

github-actions bot commented Nov 1, 2023

Summary CoverItUp: kevincobain2000/gobrew

Type master feature/gobrew
coverage 58.2 % 66.1 % +
go-binary-size 5.8k KB 5.9k KB +
go-mod-dependencies 29 28 -
go-sec-issues 6 6
build-time 5 sec 6 sec +
unit-test-run-time 68 sec 151 sec +

Generated by Cover It Up.
View full report https://coveritup.app/kevincobain2000/gobrew

@kevincobain2000 kevincobain2000 merged commit 1859f1e into master Nov 1, 2023
19 of 21 checks passed
@kevincobain2000 kevincobain2000 deleted the feature/gobrew branch November 1, 2023 09:01
@gedw99
Copy link
Contributor

gedw99 commented Nov 1, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: gobrew interactive
3 participants