Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vup 1.22 and go get -u deps #178

Merged
merged 5 commits into from Feb 10, 2024
Merged

vup 1.22 and go get -u deps #178

merged 5 commits into from Feb 10, 2024

Conversation

kevincobain2000
Copy link
Owner

No description provided.

@kevincobain2000
Copy link
Owner Author

UT are passing on local

╰─$ go test ./...
?   	github.com/kevincobain2000/gobrew/cmd/gobrew	[no test files]
ok  	github.com/kevincobain2000/gobrew	(cached)
ok  	github.com/kevincobain2000/gobrew/utils	(cached)
╭─pulkit.kathuria@JP-GCJKVGQK0G^M ~/git/gobrew ‹feature/get-u›
╰─$ go test ./... -count=1
?   	github.com/kevincobain2000/gobrew/cmd/gobrew	[no test files]
ok  	github.com/kevincobain2000/gobrew	0.416s
ok  	github.com/kevincobain2000/gobrew/utils	0.208s

@kevincobain2000 kevincobain2000 added the help wanted Extra attention is needed label Feb 10, 2024
@kevincobain2000 kevincobain2000 removed the help wanted Extra attention is needed label Feb 10, 2024
Copy link

CoverItUp Report

TYPE MASTER FEATURE/GET-U
coverage 60.5% 60.5%
build-time 3sec 3sec
go-binary-size 6.1kKB 6.1kKB
go-mod-dependencies 29 28-
go-sec-issues 6 6
unit-test-run-time 18sec 18sec

chartchartchartchartchartchart

Add Badges and Charts to Readme

@kevincobain2000 kevincobain2000 added the VUP This doesn't seem right label Feb 10, 2024
Copy link
Collaborator

@juev juev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, you are adding a check for the latest version?

I don't remember how in tests I added moki to a specific version so that it would be used as the latest one. And in this case, we don't need to add versions to testdata every time.

If I'm wrong and forgot to do this, then you need to edit the algorithm.

But in general, it is normal now.

@kevincobain2000
Copy link
Owner Author

I just wanted to update to the latest go version. But the tests failed.
To be specific, the TestInteractive was failing, but upon adding the 1.22 it was ok.

I think, the new tar.gz is required when we change the go version mod file.

@kevincobain2000 kevincobain2000 merged commit daa2f16 into master Feb 10, 2024
12 checks passed
@kevincobain2000 kevincobain2000 deleted the feature/get-u branch February 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VUP This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants