Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick the latest in order for dev-latest #180

Merged
merged 3 commits into from Feb 10, 2024
Merged

Conversation

kevincobain2000
Copy link
Owner

@kevincobain2000 kevincobain2000 commented Feb 10, 2024

Fixes #179

Semantic ordering is

[]string{
  "1.22rc1",
  "1.22rc2",
  "1.22.0",
}

I wonder if it ever worked actually. It had been there since the beginning.

@kevincobain2000 kevincobain2000 changed the title pick the latest in order pick the latest in order for dev-latest Feb 10, 2024
Copy link

CoverItUp Report

TYPE MASTER FEATURE/DEV-VERSION
coverage 60.5% 60.5%
build-time 3sec 3sec
go-binary-size 6.1kKB 6.1kKB
go-mod-dependencies 29 29
go-sec-issues 6 6
unit-test-run-time 18sec 18sec

chartchartchartchartchartchart

Add Badges and Charts to Readme

helpers.go Outdated
@@ -224,7 +224,8 @@ func (gb *GoBrew) judgeVersion(version string) string {
if len(judgedVersions) == 0 {
return "None"
}
return judgedVersions[len(judgedVersions)-1]

return judgedVersions[0]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work in progress, still needs fixing

[]string{
  "1.22rc1",
  "1.22rc2",
  "1.22.0",
}

Copy link

CoverItUp Report

TYPE MASTER FEATURE/DEV-VERSION
coverage 60.5% 59.2%-

chart

Add Badges and Charts to Readme

@kevincobain2000 kevincobain2000 added the bug Something isn't working label Feb 10, 2024
@juev
Copy link
Collaborator

juev commented Feb 10, 2024

I wonder if it ever worked actually. It had been there since the beginning.

I was aware of this problem, but I've never used specifying a dev version myself. I explicitly specify the version that is required.

@juev
Copy link
Collaborator

juev commented Feb 10, 2024

Can you describe in words the algorithm for creating and using dev versions?

Copy link
Collaborator

@juev juev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I get it, thanks!

@kevincobain2000 kevincobain2000 merged commit a6dba07 into master Feb 10, 2024
12 checks passed
@kevincobain2000 kevincobain2000 deleted the feature/dev-version branch February 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev-latest is not choosing rc version
2 participants