Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Manifest properties don't default as expected #102

Open
tmlmt opened this issue May 2, 2023 · 0 comments
Open

Manifest properties don't default as expected #102

tmlmt opened this issue May 2, 2023 · 0 comments

Comments

@tmlmt
Copy link

tmlmt commented May 2, 2023

Hi @kevinmarrec, see repro here: https://stackblitz.com/edit/nuxt-starter-ufzybv
3 issues at least:

  • The name doesn't default to the name property of package.json. The title defaults to "Nuxt PWA" although we're not seeking any hypothetical effect of a manifest property set outside of pwa like in Title is always "Nuxt PWA" #47
  • The short_name doesn't default to the same name property as advertised in the docs
  • The description doesn't default to the description property of package.json

nuxt.config.ts:

  modules: ['@kevinmarrec/nuxt-pwa'],
  pwa: {
    icon: false,
    workbox: false,
    meta: false,
  },

package.json:

{
  "name": "stackblitz",
  "description": "My description",
  "private": true,
  "scripts": {
    "build": "nuxt build",
    "dev": "HOST=0.0.0.0 nuxt dev",
    "generate": "nuxt generate",
    "preview": "nuxt preview",
    "postinstall": "nuxt prepare"
  },
  "devDependencies": {
    "@kevinmarrec/nuxt-pwa": "^0.17.0",
    "@types/node": "^18",
    "nuxt": "^3.4.3"
  }
}

resulting manifest.json:

{
  "name": "Nuxt PWA",
  "short_name": "",
  "description": "",
  "lang": "en",
  "start_url": "/?standalone=true",
  "display": "standalone",
  "background_color": "#ffffff",
  "theme_color": "#000000",
  "icons": []
}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant