Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to exclude some files from being deleted #56

Open
denniskaselow opened this issue May 23, 2019 · 9 comments
Open

A way to exclude some files from being deleted #56

denniskaselow opened this issue May 23, 2019 · 9 comments
Assignees

Comments

@denniskaselow
Copy link
Contributor

I have a CHANGELOG.md in my web-directory which I load via https://pub.dev/packages/markdown if the user wants to see the changelog. Now it just get's deleted.

Or maybe exclude the original items in the web-directory because the stuff in there usually is supposed to be deployed?

@denniskaselow denniskaselow changed the title Some way to exclude some files from being deleted A way to exclude some files from being deleted May 23, 2019
@kevmoo kevmoo self-assigned this May 23, 2019
@mirkancal
Copy link

I need that feature, it keeps deleting my CNAME. Is there any workaround or parameter to do that?

@denniskaselow
Copy link
Contributor Author

Do you have your CNAME in the web directory? Cause I have and that one isn't getting deleted, as it's not in this list of items that are deleted: https://github.com/kevmoo/peanut.dart/blob/master/lib/src/build_runner.dart#L90

@mirkancal
Copy link

I've putted manually in gh-pages branch, not the master.

@denniskaselow
Copy link
Contributor Author

Put it into the web folder of the branch where you do the development. The gh-pages branch is always getting generated in a fresh state (otherwise you wouldn't get rid of older files) and changing that would be an entirely different issue.

@mirkancal
Copy link

Thank you, it solved my problem.

kevmoo added a commit that referenced this issue May 28, 2019
kevmoo added a commit that referenced this issue May 29, 2019
@e-belair
Copy link

Until the improvement is made, I wonder if I can execute a post-deploy script to copy the .md file in the web output before committing. How can I copy the file from my project into the built output?

@aaronkelton
Copy link

I feel like folks using a custom domain for GitHub Pages and having their CNAME deleted on subsequent deploys is a major issue.

@kevmoo
Copy link
Owner

kevmoo commented Sep 22, 2023

PRs welcome!

@denniskaselow
Copy link
Contributor Author

denniskaselow commented Sep 23, 2023

I feel like folks using a custom domain for GitHub Pages and having their CNAME deleted on subsequent deploys is a major issue.

The CNAME is not getting deleted, just the list of these items:

https://github.com/kevmoo/peanut.dart/blob/master/lib/src/build_runner.dart#L112-L130

Only the **.md was a problem for me and I solved it by using an asset packer to include it in a .dart file (so it's no longer an issue for me). The CNAME issue for the other person only was because the gh-pages branch is always a clean state and they didn't have the file in their main branch. Which is not the problem this issue is about, and I don't even see this as a problem, it's working as I'd expect it to work and I'd do the same thing manually because I wouldn't want to have any leftover files kept from the last build/deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants