Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarkus-next: Replace deprecated QUARKUS_PROFILE_PROP constant #29439

Merged
merged 1 commit into from May 13, 2024
Merged

quarkus-next: Replace deprecated QUARKUS_PROFILE_PROP constant #29439

merged 1 commit into from May 13, 2024

Conversation

Pepo48
Copy link
Contributor

@Pepo48 Pepo48 commented May 10, 2024 •
edited

Closes: #29438

I decided to determine the property name/key based on the launch mode, which means it can be either quarkus.profile (for prod and dev mode) or quarkus.test.profile (for test mode).

I think this approach is in alignment with the Quarkus guidelines. Otherwise, if we would like to stick with a constant, it can be done via LaunchMode.NORMAL.getProfileKey().

cc: @vmuzikar @shawkins

@Pepo48 Pepo48 requested review from a team as code owners May 10, 2024 07:45
This was referenced May 10, 2024
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.saml.ArtifactBindingWithResolutionServiceTest#testReceiveArtifactNonExistingClient

Keycloak CI - Base IT (6)

jakarta.ws.rs.InternalServerErrorException: HTTP 500 Internal Server Error
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:250)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed May 10, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

shawkins
shawkins previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pepo48
quarkus-next: Replace deprecated QUARKUS_PROFILE_PROP constant
18987ae 
Closes: keycloak#29438

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
@Pepo48
Copy link
Contributor Author

Pepo48 commented May 10, 2024

@shawkins @vmuzikar jfyi I was told that the plan is to delete the ProfileManager class completely, so I just replaced ProfileManager.getLaunchMode().getProfileKey() with LaunchMode.current().getProfileKey(). It does the very same thing, it's just more future-proof.

@shawkins shawkins self-requested a review May 10, 2024 18:29
shawkins
shawkins approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmuzikar vmuzikar merged commit 3ec51d1 into keycloak:main May 13, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot left review comments

@shawkins shawkins shawkins approved these changes

@vmuzikar vmuzikar vmuzikar approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quarkus-next: Replace deprecated QUARKUS_PROFILE_PROP constant
3 participants
@Pepo48 @shawkins @vmuzikar