outstanding type issues

[mdrocco]

This is a spinoff of #929 , following up the first batches of type fixes in various PRs. The following files are reported to contain type issues according to pyright with Python 3.10:

• keylime/backport_dataclasses.py
• keylime/cloud_verifier_tornado.py
• keylime/da/examples/file.py
• keylime/da/examples/redis.py
• keylime/da/examples/sqldb.py
• keylime/da/examples/tsa_rfc3161.py
• keylime/da/record.py
• keylime/mba/elchecking/example.py
• keylime/ima/ima_dm.py
• keylime/keylime_agent.py
• keylime/migrations/versions/*
• keylime/revocation_actions/update_crl.py
• test/data/template-invalid-adjust/2.0/adjust.py

[mdrocco]

Here is a new one, following up #1180. The type checker reports a possibly unbounded variable in the verifier's code.

keylime/keylime/cloud_verifier_tornado.py

Line 608 in 8e417f5

session.add(VerfierMain(**agent_data, ima_policy=ima_policy_stored))

I tried the obvious fix but it breaks CI tests:

https://github.com/mdrocco/keylime/blob/ccfd29a2942eed2bed86628d7fadc44bd86b6810/keylime/cloud_verifier_tornado.py#L576-L577

[mdrocco]

Update: PR #1186 fixes the reported problems in ima/ima_dm.py, I am removing the section of the issue about that file.

[mdrocco]

Update: PR #1194 fixes the reported problems in ima/file_signatures.py and json.py, I am removing the section of the issue about those files.

[stefanberger]

Update: PR #1196 fixes the reported problems in cmd/ima_emulator_adapter.py and cmd/convert_ima_policy.py

[mdrocco]

I am restructuring this issue to keep track of all the files with outstanding type issues, considering the existing PRs.

[mdrocco]

update: upgrading Lark from 1.1.3 to 1.1.4 fixed the issue below:

/home2/mdrocco/git/keylime/keylime/ima/ima_dm.py
  /home2/mdrocco/git/keylime/keylime/ima/ima_dm.py:16:18 - error: "Lark" is not exported from module "lark"
    Import from "lark.lark" instead (reportPrivateImportUsage)
  /home2/mdrocco/git/keylime/keylime/ima/ima_dm.py:16:24 - error: "Transformer" is not exported from module "lark"
    Import from "lark.visitors" instead (reportPrivateImportUsage)
  /home2/mdrocco/git/keylime/keylime/ima/ima_dm.py:16:37 - error: "v_args" is not exported from module "lark"
    Import from "lark.visitors" instead (reportPrivateImportUsage)

[mdrocco]

update: PR #1268 (and #1308) fixed the verifier. How much do we care about the outstanding issues? @aplanas @THS-on @stefanberger

[THS-on]

I think looking at elchecking makes probably sense. The other ones are a lower priority.

[aplanas]

dataclases: that file should be ignored, and dropped once we upgrade the minimal python
da/*: that can be done later, as the issue of testing is more pressure

From the rest maybe ima and elchecking

[mdrocco]

Thanks, I will look at elchecking next. @aplanas, everything ima is type-fixed as far as I can tell.