Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): add new test for child of dependency for builder #11428

Open
mcdurdin opened this issue May 13, 2024 · 1 comment · May be fixed by #11429
Open

chore(common): add new test for child of dependency for builder #11428

mcdurdin opened this issue May 13, 2024 · 1 comment · May be fixed by #11429
Assignees
@mcdurdin
Labels
chore common/
Milestone
A18S4

Comments

@mcdurdin
Copy link
Member

For the debug-deps test, it would be nice to have an action that verifies that a child action is skipped if it was already run due to dependency mode.

So, a setup like...

parent:

builder_describe "foo" \
"@/resources/build/test/debug-deps/dep/child" \  
"@/resources/build/test/debug-deps/dep"

Of course, a more likely case is where the first 'dependency' there is triggered by a different dependency that happens to depend on dep/child.

Originally posted by @jahorton in #11410 (review)
@mcdurdin mcdurdin added this to the A18S4 milestone May 13, 2024
@mcdurdin mcdurdin self-assigned this May 13, 2024
@mcdurdin
Copy link
Member Author

This could be a little tricky. For child builds the model is that we do not look at dep status when starting the build. I will work on some test cases for this, but probably not this sprint!

mcdurdin added a commit that referenced this issue May 13, 2024
@mcdurdin
chore(common): add test for interactions between deps and children
638c920 
Fixes #11428.

It is possible for a dep to have child builds, and vice-versa. When
a dep has child builds, we want to avoid those child builds being run
twice in the scenario that the dep is also referred to directly (though
the presence of complex dependencies like this may be a red flag for our
dependency map, but that's a separate problem...)

This test does not currently fix the problem, but it starts the
exploration process.
@mcdurdin mcdurdin linked a pull request May 13, 2024 that will close this issue
Draft
@mcdurdin mcdurdin linked a pull request May 13, 2024 that will close this issue
chore(common): add test for interactions between deps and children #11429
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
chore common/
Milestone
A18S4
Development

Successfully merging a pull request may close this issue.

chore(common): add test for interactions between deps and children keymanapp/keyman
1 participant
@mcdurdin