Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session secret should remain the same between hot reloads #372

Open
flexdinesh opened this issue Oct 21, 2022 · 0 comments
Open

Session secret should remain the same between hot reloads #372

flexdinesh opened this issue Oct 21, 2022 · 0 comments

Comments

@flexdinesh
Copy link

Session secret was recently changed from static to dynamic.

The intention is good that static strings should not be used as session secrets and they should be crypto strings. But since changes hot reload the server, the session secret gets reset between hot reloads and forces the user to login again into their Admin UI for every single change during development. We should either figure out how to persist the session secret during hot reloads or revert back to the previous approach of using static string as a secret.

@flexdinesh flexdinesh changed the title Session secret should be static between hot reloads Session secret should remain the same between hot reloads Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant