From 656af112853bc344cdd42bc2451981d6f3c104d3 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Mon, 13 May 2019 11:28:01 -0700 Subject: [PATCH] fix: default enable_negotiate_port to false (#18251) --- atom/browser/net/system_network_context_manager.cc | 2 ++ atom/common/options_switches.cc | 3 +++ atom/common/options_switches.h | 1 + 3 files changed, 6 insertions(+) diff --git a/atom/browser/net/system_network_context_manager.cc b/atom/browser/net/system_network_context_manager.cc index 52e4f2673f15a..db0818c92936a 100644 --- a/atom/browser/net/system_network_context_manager.cc +++ b/atom/browser/net/system_network_context_manager.cc @@ -51,6 +51,8 @@ network::mojom::HttpAuthDynamicParamsPtr CreateHttpAuthDynamicParams() { command_line->GetSwitchValueASCII(atom::switches::kAuthServerWhitelist); auth_dynamic_params->delegate_whitelist = command_line->GetSwitchValueASCII( atom::switches::kAuthNegotiateDelegateWhitelist); + auth_dynamic_params->enable_negotiate_port = + command_line->HasSwitch(atom::switches::kEnableAuthNegotiatePort); return auth_dynamic_params; } diff --git a/atom/common/options_switches.cc b/atom/common/options_switches.cc index d7cbf532ea8d8..f551fe3a29073 100644 --- a/atom/common/options_switches.cc +++ b/atom/common/options_switches.cc @@ -263,6 +263,9 @@ const char kAuthServerWhitelist[] = "auth-server-whitelist"; const char kAuthNegotiateDelegateWhitelist[] = "auth-negotiate-delegate-whitelist"; +// If set, include the port in generated Kerberos SPNs. +const char kEnableAuthNegotiatePort[] = "enable-auth-negotiate-port"; + } // namespace switches } // namespace atom diff --git a/atom/common/options_switches.h b/atom/common/options_switches.h index 346fbcfc0cc99..93efae3b12cb8 100644 --- a/atom/common/options_switches.h +++ b/atom/common/options_switches.h @@ -126,6 +126,7 @@ extern const char kDiskCacheSize[]; extern const char kIgnoreConnectionsLimit[]; extern const char kAuthServerWhitelist[]; extern const char kAuthNegotiateDelegateWhitelist[]; +extern const char kEnableAuthNegotiatePort[]; } // namespace switches