Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-filter gets deleted on new selection #4689

Open
3 tasks done
kevinpapst opened this issue Mar 7, 2024 · 2 comments
Open
3 tasks done

Multi-filter gets deleted on new selection #4689

kevinpapst opened this issue Mar 7, 2024 · 2 comments
Labels

Comments

@kevinpapst
Copy link
Member

Describe the issue

When selecting multiple customers and projects in the search and then selecting another customer, only the first project is kept in the list of the selected projects, the other ones are removed.

That happens because the javascript that handles API filled selects does not respect select multiple.

I already tried

Kimai version

2.12.0

How do you run Kimai?

KIMAI CLOUD

Which PHP version are you using?

8.1

Logfile

No response

Screenshots

filter-bug.mp4
@kevinpapst kevinpapst added the bug label Mar 7, 2024
@Tanu1201
Copy link

hey, I am Tanu Sharma having 2 yr of exp in SDE, can I take this issue?

@kevinpapst
Copy link
Member Author

@Tanu1201 you can try, you need to setup frontend tooling.
The code is somewhere in here: https://github.com/kimai/kimai/blob/main/assets/js/forms/KimaiFormSelect.js#L234
Must have to-do with the fact that const selectedValue = node.value; only supports one selected value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants